search

feathersjs-ecosystem / feathers-redux

Integrate Feathers with your Redux store
MIT License
114 stars 23 forks source link

Move redux to peerDependencies #54

Closed petermikitsh closed 6 years ago

petermikitsh commented 6 years ago

Steps to reproduce

Have a project using redux v4.0.0 while using this module.

Expected behavior

My project only contains one copy of redux.

Actual behavior

My project uses redux@4.0.0. This project defines a dependency of redux@^3.7.2. Consequently, my application ships 2 copies of redux:

screen shot 2018-08-29 at 4 56 29 pm screen shot 2018-08-29 at 4 56 06 pm

Solution

Move redux to peerDependencies, allowing package consumers to pick the version of redux they want to use.

eddyystop commented 6 years ago

Would you mind submitting a PR for this? Thanks in advance.

petermikitsh commented 6 years ago

Hey @eddyystop I'm still using the 1.x release, would it be possible to re-release 1.x? I could make 2 PR's, one for master and (if you created a 1.x branch) I could make a PR for that too.

eddyystop commented 6 years ago

You can specify any particular release in your package.json, e.g."@feathers-plus/feathers-redux": "^1.x.x"

petermikitsh commented 6 years ago

Closing this since #55 was merged.