search

feathersjs-ecosystem / feathers-redux

Integrate Feathers with your Redux store
MIT License
114 stars 23 forks source link

isError cleared incorrectly #59

Closed Sicria closed 5 years ago

Sicria commented 5 years ago

https://github.com/feathers-plus/feathers-redux/blob/master/src/index.js#L137

This causes flashing when the error is cleared and the user is retrying a request after the previous request has failed.

It would be good if the error is only cleared on success or set again on failure.

Since the isError means that the previous request has failed, it should still show that the previous request has failed until the next request has either succeeded or failed.

eddyystop commented 5 years ago

I'm understand your point and I'm sympathetic to the issue.

The repo handles async actions as is commonly expected in Redux. The screen flicker is a side effect.

I don't see making a breaking change to the repo which conflates async actions with a UI side effect. Perhaps its best to handle this as a Redux side effect.

Feel free to reopen this issue if you have additional comments.