search

feathersjs-ecosystem / feathers-sequelize

A Feathers service adapter for the Sequelize ORM. Supporting MySQL, MariaDB, Postgres, SQLite, and SQL Server
MIT License
208 stars 75 forks source link

Warning When Starting Feathers when using Sequelize 5.10.0 with feathers-sequelize 5.1.3 #305

Closed frastlin closed 5 years ago

frastlin commented 5 years ago

Steps to reproduce

I installed the latest feathers-sequelize and the latest sequelize. When I do "npm start", I get the following message:

> node src/

(node:3147255) [SEQUELIZE0004] DeprecationWarning: A boolean value was passed to options.operatorsAliases. This is a no-op with v5 and should be removed.

Expected behavior

Nothing should show as a warning.

Actual behavior

The error shows

System configuration

Sequelize: 5.10.0 feathers-sequelize: 5.1.3

Fix

Just delete the line from the feathers generator that says:

    operatorsAliases: false,
edwardsmarkf commented 5 years ago

is it better to change to:

operatorsAliases: null,

instead of false?

interesting the documentation still says "false":

http://docs.sequelizejs.com/manual/querying.html

thank you for identifying this issue. there is a similar situation on 'logging: true'"

Thank you,

Mark Edwards

On Fri, Jul 12, 2019 at 7:10 AM Brandon notifications@github.com wrote:

Steps to reproduce

I installed the latest feathers-sequelize and the latest sequelize. When I do "npm start", I get the following message:

node src/

(node:3147255) [SEQUELIZE0004] DeprecationWarning: A boolean value was passed to options.operatorsAliases. This is a no-op with v5 and should be removed.

Expected behavior

Nothing should show as a warning. Actual behavior

The error shows System configuration

Sequelize: 5.10.0 feathers-sequelize: 5.1.3 Fix

Just delete the line from the feathers generator that says:

operatorsAliases: false,

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/feathersjs-ecosystem/feathers-sequelize/issues/305?email_source=notifications&email_token=AAWJ3YWYZVTZ5D7ZA5RGTCDP7CGHHA5CNFSM4ICKUNAKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G64P5DQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWJ3YQT726E2KCC5R7SSOTP7CGHHANCNFSM4ICKUNAA .

daffl commented 5 years ago

Don't be afraid to touch the code. Just remove operatorAliases as the message suggests. The latest CLI has been updated accordingly.