feathersjs-ecosystem / feathers-sequelize

A Feathers service adapter for the Sequelize ORM. Supporting MySQL, MariaDB, Postgres, SQLite, and SQL Server
MIT License
208 stars 74 forks source link

Allow join queries on remove #402

Closed DaddyWarbucks closed 6 months ago

DaddyWarbucks commented 2 years ago

Unfortunately the Sequelize Model.destroy method does not allow an include option. The include option is generally used to make join queries that allow the user to query/populate across tables. And it makes some sense why Sequelize would do that, its trying to handle cascades, truncates, paranoid, etc. But, this library is already making some abstractions above this like $returning, etc. I would like to update the _remove method to use the idList approach found in the _patch method.

fratzinger commented 6 months ago

resolved in #403