Log statement in the code: Remove it?

feathersjs-ecosystem / feathers-swagger

Add documentation to your FeatherJS services and feed them to Swagger UI.

MIT License

225 stars 62 forks source link

Closed andys8 closed 6 years ago

andys8 commented 6 years ago

There is a log statement inside the code. Should this be the case and users not being able to deactivate it?

console.log node_modules/feathers-swagger/lib/index.js:69
      Adding static path /<path>/node_modules/swagger-ui-dist

daffl commented 6 years ago

Yep, it should definitely be removed. debug statements would be nice though.

andys8 commented 6 years ago

Removed it, because even for a console.debug the user can not decide against it otherwise.

daffl commented 6 years ago

Sorry, I meant adding debugging statements using the Node debug module. Thanks for the PR though, that definitely shouldn't be in there.