adding CDN links for js and css files

feathersjs-ecosystem / feathers-swagger

Add documentation to your FeatherJS services and feed them to Swagger UI.

MIT License

226 stars 63 forks source link

adding CDN links for js and css files #217

Closed indatawetrust closed 2 years ago

indatawetrust commented 3 years ago

I added CDN links for assets used in docs.html file

Mairu commented 3 years ago

Currently, the swagger-ui-dist npm package is a dependency, this change is a bit contradictive to that because you would then use a different version of swagger ui than you have in your package(-lock).json

My plan for the next major version is to remove that dependency. Then the example of using a CDN would make sense.

Mairu commented 2 years ago

The removal of the swagger-ui-dist package is now implemented and the section containing the HTML file was removed from the readme. Therefore that PR is obsolete.

https://github.com/feathersjs-ecosystem/feathers-swagger/commit/104fdb61af86d04c71b98bea9f116ab6bf33a7b9#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5