feathersjs-ecosystem / feathers-swagger

Add documentation to your FeatherJS services and feed them to Swagger UI.
MIT License
226 stars 63 forks source link

[Snyk] Security upgrade swagger-ui-dist from 3.22.2 to 4.1.3 #228

Closed snyk-bot closed 2 years ago

snyk-bot commented 2 years ago

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 484/1000
Why? Has a fix available, CVSS 5.4
User Interface (UI) Misrepresentation of Critical Information
SNYK-JS-SWAGGERUIDIST-2314884
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

liquidcowgithub commented 2 years ago

So this PR has been open for a while (conscious that its a bot).

Are there any blockers to merging this in? Any possible regressions?

Mairu commented 2 years ago

Upgrading of swagger-ui to a new major version is a breaking change. A new major version of the feathers-swagger would be needed, which is the reason why this was not simply merged. I see that this is no reason to postpone this any further. But still my goal would be to remove swagger-ui-dist as direct dependency instead to not have this problem in the future again. I will try to create a new major version without swagger-ui-dist and without (additional) support for feathers dove soon.