search

feathersjs-ecosystem / feathers-sync

Synchronize service events between Feathers application instances
MIT License
221 stars 41 forks source link

added support for passing in existing redis connection to the adapter, which also enables support for ioredis; the redis ready events now race so only one will resolve/reject #103

Closed thavlik closed 4 years ago

thavlik commented 5 years ago

This adds support for passing in existing redis connection(s) to the adapter, consequently allowing support for ioredis and other clients. The redis ready events also now race so only one will resolve/reject, whereas before the error promise would reject on the first error, even after the adapter indicated it was ready. Sorry about the ugly diff.

daffl commented 5 years ago

Thank you, that makes sense. Does it need separate pub and sub connections? Also, could you add the new options to the Readme documentation?

jamesholcomb commented 4 years ago

Was curious if this PR was the recommended approach or if perhaps a refactor to ioredis would be more appropriate.

I need Redis Cluster connectivity support which ioredis handles.

daffl commented 4 years ago

Closed via https://github.com/feathersjs-ecosystem/feathers-sync/pull/146