Duplicate redisClient (bug fix) * Customize subscriber event

feathersjs-ecosystem / feathers-sync

Synchronize service events between Feathers application instances

MIT License

222 stars 41 forks source link

Duplicate redisClient (bug fix) * Customize subscriber event #155

Closed dubiousdavid closed 3 years ago

dubiousdavid commented 3 years ago

Allow for the customization of the subscriber event to use message buffers with ioredis. Could also be useful for the redis package.
Duplicate redisClient since we need two connections, one for publish and one for subscribe.

daffl commented 3 years ago

This makes sense, thank you! Two things:

1) Could you re-submit the PR against the latest development branch instead of master? 2) No need to update version numbers, that will happen automatically during release

dubiousdavid commented 3 years ago

Will do.

dubiousdavid commented 3 years ago

New PR: https://github.com/feathersjs-ecosystem/feathers-sync/pull/158