search

feathersjs-ecosystem / feathers-sync

Synchronize service events between Feathers application instances
MIT License
221 stars 41 forks source link

NATS 2.0 #175

Closed ViljarVoidula closed 2 years ago

ViljarVoidula commented 2 years ago

Summary

NATS 2.0 basic support for sync

https://github.com/feathersjs-ecosystem/feathers-sync/issues/163

daffl commented 2 years ago

Wonderful, thank you! We can totally get this published, just a couple of notes:

ViljarVoidula commented 2 years ago

Wonderful, thank you! We can totally get this published, just a couple of notes:

  • Tests run on GitHub actions now so we don't need the .travis.yml. Looks like the action already pulls down the right version in https://github.com/feathersjs-ecosystem/feathers-sync/blob/release/.github/workflows/ci.yml but it might have to be updated. It looks like the tests in this PR are passing though.
  • Can we keep the original code style in the readme (single quotes, no trailing commas - I saw there was in there before, which should probably be removed as well)?

@daffl - yeah, so sorry, i'm puzzled about code style , seems fresh VS Code thought it is time to "fix it" behind my back on save. Should be fixed now, also deleted the deprecated travis file.

daffl commented 2 years ago

Fantastic, thank you! Interesting that it only changed the code style in the readme, thank you for updating that.