[x] Tell us what broke. The more detailed the better.
If passing a redisClient object as shown in Exhibit 1, current code will throw an error as it is expecting the uri. However, when passing the redisClient the uri is not required.
Exhibit 1
app.configure( sync({ redisClient }) );
[x] If you can, please create a simple example that reproduces the issue and link to a gist, jsbin, repo, etc.
You can reproduce by configuring feathersjs sync as shown in the Exhibit 1 snipplet above.
Expected behavior
Code should not generate an error when a redisClient object is passed.
Actual behavior
Code throws the error: A uri option with the database connection string, or a redisClient object has to be provided to feathers-sync
Steps to reproduce
If passing a redisClient object as shown in Exhibit 1, current code will throw an error as it is expecting the uri. However, when passing the redisClient the uri is not required.
Exhibit 1
app.configure( sync({ redisClient }) );You can reproduce by configuring feathersjs sync as shown in the Exhibit 1 snipplet above.
Expected behavior
Code should not generate an error when a redisClient object is passed.
Actual behavior
Code throws the error: A
urioption with the database connection string, or aredisClientobject has to be provided to feathers-syncI have resolved the issue and created a pull request at: https://github.com/feathersjs-ecosystem/feathers-sync/pull/196