redis adapter

[kc-dot-io]

Summary

I want to be able to use feathers-sync with redis to distribute events across nodes.

Changes

• [x] move lib => src to follow newer repos
• [x] rename package to sync
• [x] rename repo to feathers-sync
• [x] clean up debug messages
• [x] changed interface to sync('redis', {}) where first argument is the adapter, the second is options
• [x] updates to readme
• [x] existing tests pass
• [x] new tests

[kc-dot-io]

• Travis looks like it just needs redis added and the existing tests should still pass.
• When I tested mongo vs redis, redis seemed to be significantly faster
• Need to clean up the way the pub / subs are created, might have to build an array of clients

[daffl]

This is awesome, thank you! It looks like Travis CI does not have a Redis server running. Adding

services:
  - redis-server

To .travis.yml should fix it. Once the tests are passing I will merge and after that do a little bit of refactoring I've been planning on for a while already (e.g. all our up-to-date plugins have been migrated to ES6).

[kc-dot-io]

Cool, are you happy with it the way it is based on the notes I added above? I'm happy to leave those be if you have some bigger refactors you want to throw down.

I'll add the redis-server now.

[kc-dot-io]

I'm adding tests for redis - don't merge yet

[daffl]

Nice, the tests passed. I'd say let's merge it, I'll migrate everything to ES6 and then we can iterate to see if there are ways to improve it. Sounds good?

[daffl]

Well once you added the tests I mean.

[kc-dot-io]

Yeah I'm just fixing a couple things real quick on test coverage. I'll ping you shortly.

[kc-dot-io]

@daffl ok i'm done! merge away.

[kc-dot-io]

btw, it should be ready to be npm published to feathers-sync now if you want to release it there

[marshallswain]

This is so awesome! Thanks for adding this.

[daffl]

Perfect. I'll update it to ES6 later today. One thing I may add to the refactoring is removing the redis and mubsub dependencies and passing them in your application. Something like:

var sync = require('feathers-sync');
var redis = require('redis');

app.configure(sync(sync.redis(redis)));

That way this module doesn't install dependencies you don't use (we've done a similar thing for the database adapters). Thoughts?

[ekryski]

Awe yeeeaaaah! Thanks @slajax!

[kc-dot-io]

@daffl I agree with your suggestions. I was thinking exporting them directly would make sense initially because they probably have different options arguments but also it would be an even more ideal scenario to abstract out the dependencies to other repos to save installing mubpub if you use redis so :+1:

Will the current version be published to NPM as a 0.2.0 or do you intend to do these refactors first? My reason for asking is purely selfish, I want to use the current version in my builds up until that refactor is ready.