search

feathersjs-ecosystem / feathers-sync

Synchronize service events between Feathers application instances
MIT License
222 stars 41 forks source link

Add function to sync a service dynamically after app launch #82

Closed claustres closed 6 years ago

claustres commented 6 years ago

This PR allow to sync services that have been created after the app has been launched, i.e. after app.listen().

We only applied the fix to our use case: MongoDB and Auk release. We created a branch starting from v0.1.4 since only a tags seem to exist on Auk compatible releases.

We believe it should be great to make it available as well on V3.

daffl commented 6 years ago

This PR looks like it was made against a much older version than current master (which should already support the feature you are looking for)?

daffl commented 6 years ago

Also, feathers-sync@^1.0.0 should also still work with older versions of Feathers (although I still can't recommend enough to try and upgrade 😉).

daffl commented 6 years ago

I feel like many people still seem to either

claustres commented 6 years ago

Yes this PR is for old v0.1.4, because no branch do exists for auk release Github forced us to PR against master. For some modules like this one we look for the Update to Feathers v3 and new plugin infrastructure commit message to know the version from which you switched to V3 (same with e.g. https://github.com/feathersjs-ecosystem/feathers-stripe). Unfortunately we don't really know if the module is still able to run with V2, I think only the core team knows !

We are not really afraid about the migration that's just we have other top priorities right now and different modules/applications already in production. Migrating everything will take some time even if simple to do (not to say regression testing).

daffl commented 6 years ago

Yeah, that makes sense. Well, me being the core "team" at the moment says that the there is no reason that the latest version wouldn't work with old Feathers but I haven't tested it 😉

I have no idea how many users there still are for the pre 1.x version but I would like to try and not having to maintain separate branches and publishing new features on older versions if possible (esp. when it is already included in the latest).