search

feathersjs-ecosystem / feathers-twilio

A Feathers service for talking to the Twilio API
MIT License
7 stars 4 forks source link

Simple update #11

Closed leoj3n closed 5 years ago

leoj3n commented 5 years ago

This makes everything use the latest versions of libraries.

Testing example/app.js with legit credentials/numbers works but npm test fails:

> istanbul cover node_modules/mocha/bin/_mocha -- --opts mocha.opts

  Twilio Call Service
    1) "before all" hook
    2) "after all" hook

  Twilio SMS Service
    Initialization
      when missing accountSid key
        ✓ throws an error
      when missing authToken
        ✓ throws an error
    Validation
      3) "before all" hook
      4) "after all" hook
    Sending messages
      from field passed in with create
        5) "before all" hook
        6) "after all" hook
      from field passed in as option
        7) "before all" hook
        8) "after all" hook

  2 passing (48ms)
  8 failing

I updated all dependencies, including dev deps. Not sure what to do about tests not passing.

leoj3n commented 5 years ago

Swapped out these changes in the feathers-twilio package of a working app.

The app continued to work as expected.

Published a package with the changes from this PR here:

https://www.npmjs.com/package/@leoj3n/feathers-twilio

daffl commented 5 years ago

Thank you for the pull request! I pulled your changes in and fixed the tests in #12 and released it with additional changes from #13 and enabled Greenkeeper.

I also added you as a collaborator so you can push directly to this repository. Personally, I am not using this module and am not interested in maintaining open source integrations for paid third party services so I will leave it up to you to keep things up to date here 😄 If you are not interested or don't have the time, we can always archive and deprecate it eventually.