search

feathersjs-ecosystem / socketio

[MOVED] The Feathers Socket.io websocket transport plugin
https://github.com/feathersjs/feathers
MIT License
37 stars 14 forks source link

Typescript definition bug #63

Closed superbarne closed 7 years ago

superbarne commented 7 years ago

Steps to reproduce

it should be: declare function socketio(connections:any, options?:any):Function; right? https://github.com/feathersjs/feathers-socketio/blob/master/client.d.ts#L3

Expected behavior

Because it returns a Function: https://github.com/superbarne/feathers-socketio/blob/master/src/client.js#L18

daffl commented 7 years ago

Sounds about right. If you submit a PR with the fix we can get a patch out right away.

superbarne commented 7 years ago

@daffl done

daffl commented 7 years ago

Closed via #64