search

feathersjs-ecosystem / socketio

[MOVED] The Feathers Socket.io websocket transport plugin
https://github.com/feathersjs/feathers
MIT License
37 stars 14 forks source link

Add port argument #69

Closed kostia-official closed 7 years ago

kostia-official commented 7 years ago

I added port argument according to these discussions https://github.com/feathersjs/feathers-socketio/pull/66 Please check.

Closes https://github.com/feathersjs/feathers-docs/issues/461

daffl commented 7 years ago

That looks great, thank you! Could you create another PR that adds the appropriate documentation below https://docs.feathersjs.com/api/socketio.html#appconfiguresocketiooptions--callback ? Then we can merge and release.

kostia-official commented 7 years ago

@daffl Okay, I've added information about the port argument. https://github.com/feathersjs/feathers-docs/pull/527

daffl commented 7 years ago

Awesome, thank you! Released as v1.6.0 and documentation has been published as well.

ekryski commented 7 years ago

Nice @kozzztya! Thanks for all the great PRs! 😄

kostia-official commented 7 years ago

You're welcome.