Dark mode (closes #1378)

mhillerstrom commented 3 years ago

An implementation of the suggestions of @matiaslopezd.

The dark mode CSS can be changed in theme/layouts/Layout.vue. Had to implement Font Awesome to get the Lightbulb (and ThumbsUp), but tree-shaking makes this a minor addition.

Hopefully, Dark-Moders will thrive with this addition!

matiaslopezd commented 3 years ago

Excellent!! 👏🏻👏🏻👏🏻

daffl commented 3 years ago

Awesome, this is great! From the build error it looks like the following dependencies still need to be added to the package.json:

@fortawesome/free-solid-svg-icons
@fortawesome/vue-fontawesome
@fortawesome/fontawesome-svg-core

mhillerstrom commented 3 years ago

Strange, because it works perfectly on my machine and ‘npm run netlifly’ compiles both client and server without any problems (it complains about an old browser list…).

Can it be due to not including ‘package-lock.json’ in the commit?

/Michael

From: David Luecke notifications@github.com Reply to: feathersjs/docs reply@reply.github.com Date: Sunday, 8 November 2020 at 21.24 To: feathersjs/docs docs@noreply.github.com Cc: Michael Hillerström michael@hillerstrom.name, Author author@noreply..github.com Subject: Re: [feathersjs/docs] Dark mode (closes #1378) (#1507)

Awesome, this is great! From the build error it looks like the following dependencies still need to be added to the package.json: @fortawesome/free-solid-svg-icons @fortawesome/vue-fontawesome @fortawesome/fontawesome-svg-core — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mhillerstrom commented 3 years ago

@daffl I omitted package-lock.json in my commit - now it passes all gates.

daffl commented 3 years ago

Perfect, this is now available at https://docs.feathersjs.com. Thank you very much for the contribution!

J3m5 commented 3 years ago

Just noticed it, this is awesome! Thank you @mhillerstrom!

feathersjs / docs

Dark mode (closes #1378) #1507