syntax highlighting isn't so colourblind / accessibility compliant

feathersjs / docs

[MOVED] Legacy Feathers documentation

https://crow.docs.feathersjs.com/

MIT License

242 stars 532 forks source link

syntax highlighting isn't so colourblind / accessibility compliant #1522

Closed kud closed 2 years ago

kud commented 4 years ago

Hello,

I just discovered your framework, which seems to be really really good but the documentation and mostly the syntax highlighting is not really easy to read.

As a bit colourblind, it's tough for me to read your documentation, it really needs more contrast.

Example on background + require():

PixelSnap 2020-05-13 at 12 11 57

Could you check this please?

Contact me if you need more information / suggestion. :)

Thanks!

daffl commented 4 years ago

That makes sense. Is it just the green or with other highlighting colours as well? The CSS can be found at https://github.com/feathersjs/docs/blob/master/.vuepress/theme/styles/code.styl#L6 I'm thinking of changing all the lighten 20% to darken instead.

kud commented 4 years ago

I see them all to be fair but it's just that the whole thing isn't enough contrasted so yeah any colour.

If you have a preview, I'll be glad to give you a feedback.

daffl commented 3 years ago

I was very much looking forward to the website redesign but it looks like that is no longer going to happen any time soon. The docs however do now have a dark mode toggle which should offer better contrast.

daffl commented 2 years ago

The docs redesign has finally happened and should also address this as well. Preview at https://dove.feathersjs.com/

kud commented 2 years ago

Wow, congrats! Amazing doc 😌