feathersjs / docs

[MOVED] Legacy Feathers documentation

https://crow.docs.feathersjs.com/

MIT License

242 stars 532 forks source link

fix helmet compatibility and remove innerHTML use in starter code #1545

Closed FossPrime closed 11 months ago

FossPrime commented 2 years ago

Starter code has the following issues:

inline attribute script, which the default feathers(helmet()) call disallows
innerHTML which will break any event listeners in #493
- injection hazard

Screenshot of this exact code actually working...

Note:

The server is running dove. The client is unchanged 4.3
Messages are still not sorted, leaving that as exercise for the reader

Screenshot from 2021-09-22 21-07-11

netlify[bot] commented 2 years ago

❌ Deploy Preview for feathers-docs failed.

🔨 Explore the source changes: 3d372b646a1dfceea4c14ebad1b6e03c79985f5f

🔍 Inspect the deploy log: https://app.netlify.com/sites/feathers-docs/deploys/614e2ab94cf23e000804c178

daffl commented 2 years ago

Thank you for the pull request. I don't think the messages.data change is correct though. The service defined in the An API server section returns this.messages in find which is an array.

FossPrime commented 2 years ago

Thank you for the pull request. I don't think the messages.data change is correct though...

I thought feathers-memory was as simple as it got. Good to know.

daffl commented 2 years ago

It is but this one is a custom service 😄