search

feathersjs / docs

[MOVED] Legacy Feathers documentation
https://crow.docs.feathersjs.com/
MIT License
242 stars 531 forks source link

Fix browser `fetch` configuration example #1563

Closed strarsis closed 2 years ago

strarsis commented 2 years ago

The browser fetch configuration example (FeathersJS REST client) doesn't bind window to fetch, the fetch used by the FeathersJS REST client won't have the right this context of window, which causes a JavaScript error:

Uncaught (in promise) Error: Failed to execute 'fetch' on 'Window': Illegal invocation

Related issue: https://github.com/josx/ra-data-feathers/issues/177

netlify[bot] commented 2 years ago

✔️ Deploy Preview for feathers-docs ready!

🔨 Explore the source changes: 4be42956e0695f802c5d3446dc39f47c58bc8746

🔍 Inspect the deploy log: https://app.netlify.com/sites/feathers-docs/deploys/6230b7fb7ddbfd00081b2833

😎 Browse the preview: https://deploy-preview-1563--feathers-docs.netlify.app

daffl commented 2 years ago

Interesting, I'm curious when this changed. Thanks for putting it up!