search

feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
15.07k stars 752 forks source link

refactor: Knexfile no longer relies on app #2931

Closed AshotN closed 1 year ago

AshotN commented 1 year ago

Summary

This PR comes after this Discord thread

This solves the issue of Knex migrations relying on the Feathers app to load it's configuration. Currently any errors in the Feathers app will prevent Knex from running it's migrations.

netlify[bot] commented 1 year ago

Deploy request for feathers-dove rejected.

Name Link
Latest commit 38188897746b485a55cc2d6acfb1457b46a8d9e8
daffl commented 1 year ago

This looks good, I'm not sure why the test is failing. Can you merge with latest dove and see if that fixes it?

AshotN commented 1 year ago

Hmm, still failing, not sure why...

e-kibet commented 1 year ago

Oops! Guess it is something to do with the pipeline runner

daffl commented 1 year ago

I'm going to close this since I'm not sure why the tests are failing. Maybe a new PR against latest will work though I found myself needing the app in my migrations a few times now.