search

feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
15.07k stars 752 forks source link

fix(typescript): Make main type names more discernible #3001

Closed daffl closed 1 year ago

daffl commented 1 year ago

This pull request changes the built in type names so that they are more easily to differentiate from the actual application type names. The problem was that TypeScript IDEs ended up auto importing the generic Application and HookContext types instead of the application specific ones so you don't get the correct service and configuration types.

netlify[bot] commented 1 year ago

Deploy Preview for feathers-dove canceled.

Name Link
Latest commit ed69538e6b4914982d202751eba4dc01922d4cc3
Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/63cec30f9b8fde00087c3b11
daffl commented 1 year ago

This actually requires a few more changes, might revisit this later if it turns out to be a continued problem for people.