search

feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
15.07k stars 752 forks source link

fix(schema): Ensure that resolveResult and resolveExternal are run as around hooks #3032

Closed daffl closed 1 year ago

daffl commented 1 year ago

3004 introduced a change in the hook order to fix a regression in compatibility with v4. However, this breaks some app generated with v5 pre releases where resolveResult and resolveExternal were registered as after hooks. Since resolveResult should be used as an around hook anyway for proper virtual property support, they will now throw an error if they are used as after hooks.

netlify[bot] commented 1 year ago

Deploy Preview for feathers-dove canceled.

Name Link
Latest commit 059ff5e18d4c0f03d7058dfcc8d777a03a6c9ad3
Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/63d89fcf32c3460008be50cd