fix: generated app does not start when choosing JSON schema

feathersjs / feathers

The API and real-time application framework

https://feathersjs.com

MIT License

15.03k stars 748 forks source link

fix: generated app does not start when choosing JSON schema #3034

Closed w3cj closed 1 year ago

w3cj commented 1 year ago

Summary

[x] Tell us about the problem your pull request is solving.
- After generating an app with "JSON schema" definition format
- Error Property '$id' is missing in type is thrown for the file src/configuration.ts
- Error Cannot redeclare block-scoped variable 'userDataSchema'. is thrown for src/services/users/users.schema.ts
[x] Are there any open issues that are related to this?
- No
[x] Is this PR dependent on PRs in other repos?
- No

netlify[bot] commented 1 year ago

Deploy request for feathers-dove rejected.

Name	Link
Latest commit	c33207f3243e1c67dee757e4c761a4350f7a97ab

daffl commented 1 year ago

Oof, sorry about that! Once again learned the lesson that if it isn't covered with tests it will break at some point 😆 I now added full JSON schema tests to the CI test matrix in https://github.com/feathersjs/feathers/pull/3035 and with your fix they all pass now, thank you!

feathersjs / feathers

fix: generated app does not start when choosing JSON schema #3034

Summary

‼️ Deploy request for feathers-dove rejected.

Deploy request for feathers-dove rejected.