search

feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
15.04k stars 751 forks source link

Make service optional in App.use #3205

Closed FossPrime closed 1 year ago

FossPrime commented 1 year ago

I'm not sure why this isn't being caught automatically... but we should definitely not skipLibCheck on things we control. If we depend on something with bad TS... perhaps we shouldn't.

skipLibCheck should remain the default for userland of course.

Screenshot 2023-06-03 11 35 28

https://github.com/feathersjs/feathers-chat/blob/dove/feathers-chat-ts/src/app.ts#LL22C40-L22C40 https://stackblitz.com/edit/node-tnne2i?file=app.ts%3AL46

daffl commented 1 year ago

The middleware extensions are added by the Koa module but looking at the warning, it looks like it'll require the esModuleInterop: true TypeScript setting.