feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
14.98k stars 743 forks source link

fix(generators): use `export type` vs `export` #3246

Closed b-steel closed 8 months ago

b-steel commented 12 months ago

Summary

Change export { NextFunction } to export type { NextFunction } and change authentication generator to look for either version when inserting new code.

daffl commented 9 months ago

I believe this should work and I'm not entirely sure why the tests are failing. Could you merge with latest and see if that works?

b-steel commented 8 months ago

@daffl Yeah I was a bit confused as well, the error from the tests was rather cryptic. I merged the latest and it seems to be passing now.

daffl commented 8 months ago

Thank you! Will go out with the next release.