search

feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
14.98k stars 743 forks source link

remove lodash/emit and flatten #3253

Closed marshallswain closed 11 months ago

marshallswain commented 11 months ago

Replace lodash/flatten with Array.prototype.flat() Replaces lodash/omit with _.omit from the @feathersjs/commons package.

daffl commented 11 months ago

It looks like something is failing. May just need to be updated or it's something else. Also, can we remove the Lodash dependency completely then?

daffl commented 11 months ago

Ok, so I verified that this is legitimately failing because Lodash's _.omit supports . separated field name. I'm inclined to close this unless we can remove the dependency completely without loosing any functionality (which doesn't seem to be the case here).