search

feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
14.97k stars 744 forks source link

Update strategy.ts #3267

Closed MarcGodard closed 9 months ago

MarcGodard commented 10 months ago

Summary

See https://github.com/feathersjs/feathers/issues/3266

daffl commented 10 months ago

Thank you for the pull request. I wonder why the profile ends up being undefined - I don't think it should.

The problem with this solution is that if the profile is undefined, it would set <provider>Id to 'undefined' for every user.

MarcGodard commented 9 months ago

Not sure either. But either way this can be managed in the authentication code. If anything that might be the best solution and to remove this from the strategy?