search

feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
14.97k stars 744 forks source link

fix(memory): Ensure correct pagination totals #3307

Closed DaddyWarbucks closed 9 months ago

DaddyWarbucks commented 9 months ago

This PR addresses the comments made at https://github.com/feathersjs/feathers/pull/2844.

When pagination is enabled, the total is now correct and essentially works as things used to. There are two changes from the original implementation.

1 - We check hasQuery before running the matcher. This is something I mentioned in my first PR. It just means that for our most basic calls like service.find() that we don't match the whole array for no reason.

2 - We now also add this.id in _select(value, params, this.id)). This ensures that the record ID is always selected, and is more in line with how most of the the DB adapters work. We may or may not want this, but its something to note as you guys are moving this over to Wings.

daffl commented 9 months ago

Thank you for fixing that! Will go out shortly.