feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
15.04k stars 751 forks source link

no exported member 'RouteLookup' #3322

Closed fidelio314 closed 10 months ago

fidelio314 commented 11 months ago

Steps to reproduce

When executing on a new typescript project (v5) the npm run compile

i have this error when compiling: The scenario is:

npm create feathers@latest feather-app

then selected: express as transport and REST (no real time) + SQL db adapter. Then

npm install

then

> npm run compile

> feather-app@0.0.0 compile
> shx rm -rf lib/ && tsc

node_modules/@feathersjs/express/lib/declarations.d.ts:4:119 - error TS2305: Module '"@feathersjs/feathers"' has no exported member 'RouteLookup'.

4 import { Application as FeathersApplication, Params as FeathersParams, HookContext, ServiceMethods, ServiceInterface, RouteLookup } from '@feathersjs/feathers';
                                                                                                                        ~~~~~~~~~~~

Found 1 error in node_modules/@feathersjs/express/lib/declarations.d.ts:4

Expected behavior

The typescript compilation should work

Actual behavior

Constantly compiling breaks.

System configuration

Module versions feathesjs versions:

"@feathersjs/adapter-commons": "^5.0.11",
"@feathersjs/authentication": "^5.0.11",
"@feathersjs/authentication-client": "^5.0.11",
"@feathersjs/configuration": "^5.0.11",
"@feathersjs/errors": "^5.0.11",
"@feathersjs/express": "^5.0.11",
"@feathersjs/feathers": "^5.0.11",
"@feathersjs/knex": "^5.0.11",
"@feathersjs/schema": "^5.0.11",
"@feathersjs/transport-commons": "^5.0.11",
"@feathersjs/typebox": "^5.0.11",

NodeJS version: 18.18.2

Operating System: ubuntu 23.10

fidelio314 commented 11 months ago

it seems that the decalration of RouteLookup was added on this file packages/express/src/declarations.ts on this commit

https://github.com/feathersjs/feathers/commit/26aa937c114fb8596dfefc599b1f53cead69c159#diff-8a215d34dc2acdeff0871a1946ad1c914ebf5c039cfdb080c994c3d5652d6ac9 " thought i dont understand why as the package feathersjs/feathers does not export it