feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
14.97k stars 742 forks source link

fix(generators): Use cross-platform ES module __dirname #3402

Closed daffl closed 5 months ago

daffl commented 5 months ago

More ES module shenanigans because they actually don't work well 😞

cloudflare-pages[bot] commented 5 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 467b3fc
Status: âœ…  Deploy successful!
Preview URL: https://dce6a880.feathers.pages.dev
Branch Preview URL: https://file-url-to-path.feathers.pages.dev

View logs

fratzinger commented 5 months ago

FYI: This is better since node v20.11.0 / v21.2.0. Once we deprecate lower versions in the future, we can switch to

import.meta.dirname

see https://twitter.com/wesbos/status/1745882792120955268 see https://github.com/nodejs/node/pull/48740