feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
14.97k stars 742 forks source link

test(adapter-tests): NotFound integer & add remove:NotFound tests #3486

Closed fratzinger closed 1 month ago

fratzinger commented 1 month ago

This PR adds tests to @feathersjs/adapter-tests:

  1. add test for id as number: The tests for NotFound (.get, .update, .patch) use a string as id. This does not work for postgres + sequelize with serial ids because sequelize throws a GeneralError with invalid input syntax for type integer: "568225fbfe21222432e836ff" which is perfectly fine. I added tests for an integer id. So every adapter can pick which tests to use.
  2. .remove + NotFound was missing. Added it and also added .remove + NotFound (integer)