feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
15.08k stars 752 forks source link

HTML5 HTTP/2 SSE Transport Support #369

Open ubergarm opened 8 years ago

ubergarm commented 8 years ago

I love that Feathers builds out API endpoints for services with both REST and multiple websocket providers. It may be of interest to additionally support an HTTP/2 SSE transport provider.

http://docs.feathersjs.com/providers/

I searched for this issue but didn't find it yet despite it being mentioned 4 months ago on a hacker news discussion (referenced below).

Thanks!

https://hn.algolia.com/story/11290577/feathers-2-0-a-minimalist-real-time-javascript-framework

N nailer  - 4 months ago
> exposes both a RESTful and real-time API automatically through HTTP/HTTPS and over websockets.
Why not both at once with HTML5 SSE?

M Matthias247 - 4 months ago
I think SSE has two limitations that might not make it too useful for some scenarios:
- Each SSE channel would require a separate TCP connection. And as the connections for a browser are limited, you can not support a lot of of different SSE channels. This is mainly a HTTP/1.1 problem, HTTP/2 fixes this. But as browser and server support for HTTP/2 is still limited you might not bet on it.
- SSE can only send chunks of text in each notification, where the possible payload is additionally limited by the SSE encoding (you can't send text with <br /><br /> in it). So if you need binary or abritrary (JSON?) text objects you would need some additional encoding. Like object -> json string -> byte-array representation -> base64 string. This works, but the overhead for your application (must do the encoding) and the browser (must to all the decoding and look for the <br /><br />) is not ideal.
I'm currently experimenting with using HTTP/2 and fetch API with readable streams to stream arbitrary objects on a bigger number of parallel channels from server to client. This seems to work and looks quite promising for the future, but due to missing browser and partly also missing server support the solution is definitely in it's infancy.
So the current safe bet for enabling lots of notification channels or enabling realtime queries would still be websockets.

D daffl - 4 months ago
That sounds like something worth keeping track of. Do you want to create an issue at https://github.com/feathersjs/feathers/issues for it? The nice thing is that you most likely won't have to change your services when adding a new transport layer.
daffl commented 8 years ago

From what I could see, it does not seem as if Express will support HTTP2 any time soon so this will be very dependent on #258.

ekryski commented 8 years ago

I did do some spelunking in this area a couple weeks back. I guess you can get it to work with Express5 but who knows what is going on with that branch. Here's an example from Stackoverflow.

There is also the spdy module which is great but I've heard is becoming deprecated in favour of a more strict http2 module.

Realistically, it definitely depends on #258 and likely not something that will happen in the very near term.

bonesoul commented 8 years ago

@daffl it's quite easy to implement a http2 server with: https://github.com/indutny/node-spdy

ekryski commented 8 years ago

I had some discussion about this in Slack with @MichaelErmer. He's using Nginx like so:

docker(feathers)=>docker_volume(unixsocket)=>docker(nginx)

with Nginx handling http2. IMHO this might be the more appropriate way to do things and Feathers likely shouldn't care about HTTP2 directly with the following caveats:

Barring those considerations it may or may not make sense to include HTTP2 as a transport. Still some more investigation to do....

muloka commented 7 years ago

Restify is adding http/2 support https://github.com/restify/node-restify/pull/1489

zhakhalov commented 6 years ago

I agree that using nginx Feathers shouldn't care about HTTP/2 it even more it may be mounted even without SSL but nevertheless here's my working example:

// at the the very bottom of the app.js

// Enable https server
const ssl = app.get('ssl'); // get ssl configurations from config.json
let server;

if (ssl) {
  server = spdy.createServer({
    key: fs.readFileSync(path.resolve(__dirname, ssl.key)),
    cert: fs.readFileSync(path.resolve(__dirname, ssl.cert)),
  }, app);
} else {
  server = spdy.createServer(app);
}

app.setup(server);

module.exports = { app, server };

// index.js
const { app, server } = require('./app');
const port = app.get('port');

// feathers-socketio explicitly creates http server
server.listen(port); // call `listen` on the server
avimar commented 4 years ago

You can install spdy and use that as the server, as mentioned above: https://github.com/feathersjs/feathers/issues/369#issuecomment-370965592

https://www.ssllabs.com/ssltest/analyze.html gave me the same A+ score for https vs spdy and all related notes- just some had a handshake of spdy or h2

strarsis commented 2 years ago

Is HTTP2 now supported in 2022? Can I implement a SSE source now with FeathersJS? I also want to terminate HTTPS/HTTP2 using Traefik in front of the FeatherJS app.

strarsis commented 2 years ago

Yes, using a reverse proxy like Traefik in front of the FeathersJS app for HTTP/2 support alleviates the connection limit for SSE. It should also bring basically all advantages of HTTP/2 (the connection between the FeathersJS app and Traefik is usually very, very fast and low-latency anyway).

strarsis commented 2 years ago

It is relatively simple to add SSE to a FeathersJS app - however, one thing I hadn't been able to solve is that the FeathersJS app hangs while the SSE request runs.

import { createSession, createChannel } from 'better-sse';
import { IncomingMessage, ServerResponse } from 'http';

export default function (app: any): void {
  const debugSseSource = require('debug')('sseSource');
  const sseChannel = createChannel();

  // Order creations
  const orders: any = app.service('orders'); // use endpoint URL

  app.get('/v1/admin/orders', async (req: IncomingMessage, res: ServerResponse) => {
    // on new connections, add SSE session to SSE channel
    const sseSession = await createSession(req, res);
    sseChannel.register(sseSession);
    debugSseSource('Client (orders) has joined.');
    //res.end(); // @TODO/PROBLEM without the whole FeathersJS app hangs - but it stops the request...
  });

  orders.on('created', (order: any) => {
    // broadcast to all clients
    debugSseSource('order created');
    sseChannel.broadcast(order, 'created');
  });
};

Related SO discussion: https://stackoverflow.com/a/71466957/4150808

emeagenciadigital commented 1 year ago

2023 any update ?

strarsis commented 1 year ago

+1, as SSE is ideal for notifications / browser push, even better so than web sockets.

I had a discussion on Discord about adding SSE natively, the concensus was that Websockets are a kind of functional superset of SSE. Maybe add a plugin package for FeathersJS that adds SSE?