feathersui / feathersui-starling

User interface components for Starling Framework and Adobe AIR
https://feathersui.com/learn/as3-starling/
Other
914 stars 386 forks source link

Scroller: added stage check in nativeStage_mouseWheelHandler() to avo… #1794

Closed esidegallery closed 4 years ago

esidegallery commented 5 years ago

…id potential null object reference error

joshtynjala commented 5 years ago

I'll merge when I get a chance. However, it is worth mentioning that this event listener is removed when the scroller is removed from stage. It shouldn't be called when stage is null...

You may have a scroller that is disposed without removing it from stage, which is a memory leak. Or the scroller was disposed before removing it from stage, which is also bad because the removedFromStage listener was not allowed to clean things up properly.