feathr-ai / feathr

Feathr – A scalable, unified data and AI engineering platform for enterprise
https://join.slack.com/t/feathrai/shared_invite/zt-1ffva5u6v-voq0Us7bbKAw873cEzHOSg
Apache License 2.0
1.98k stars 260 forks source link

Azure job url is not set and thus not logged correctly during error. #326

Closed bozhonghu closed 2 years ago

bozhonghu commented 2 years ago

It seems like the job url for the azure job is not set. The error log here does not work: https://github.com/linkedin/feathr/blob/85c2bf50337bdd32f3e63bb521d9aa55f994736c/feathr_project/feathr/_synapse_submission.py#L138

logger.error("Feathr job has failed. Please visit this page to view error message: {}", self.job_url)
E               AttributeError: '_FeathrSynapseJobLauncher' object has no attribute 'job_url'
feathr_project/feathr/_synapse_submission.py:138: AttributeError

^ is the error I see. It seems like the variable self.job_url is not set anywhere

windoze commented 2 years ago

Fixed in #327