search

feathr-ai / helm-charts

Apache License 2.0
1 stars 0 forks source link

Added Secret #13

Closed ahlag closed 1 year ago

ahlag commented 1 year ago

Description

Added secrets as environment variables for Feathr Resolves https://github.com/feathr-ai/helm-charts/issues/9

How was this PR tested?

Secrets are stored as environment values in Feathr Pod.

  1. Set any string in secrets.yaml.
  2. Run helm install chang ./feathr-online \ --set pipelineConf=$(cat <path>/pipeline.conf | base64) \ --set lookup=$(cat <path>/lookup.json | base64) to install deployment.
  3. ssh into the Feathr pod and run, for example echo $CONN_STR in the case the secret for CONN_STR is set in the secrets.yaml

Does this PR introduce any user-facing changes?

ahlag commented 1 year ago

@blrchen Could you check how we should pass secret from helm? Should it be written to secret.yaml?