search

feature-engine / feature_engine

Feature engineering package with sklearn like functionality
https://feature-engine.trainindata.com/
BSD 3-Clause "New" or "Revised" License
1.88k stars 310 forks source link

add fill_value to RelativeFeatures for when dividing by zero #663

Closed solegalli closed 1 year ago

solegalli commented 1 year ago

closes #653 closes #577

FYI @Morgan-Sell

Making this PR due to rebase conflicts

solegalli commented 1 year ago

Hey @Morgan-Sell

Would you have time to review this?

Morgan-Sell commented 1 year ago

hola @solegalli,

I hope one day I'm half the data scientist as Dr. Che!

Sorry for missing the _floordiv(), _truediv(), and _mod() methods. Also, I like how you created the _find_zeroes_in_reference() method.

The PR looks great! My only comment/question is due to curiosity.

Lastly, did you discover the root of the rebase conflicts?

solegalli commented 1 year ago

Thank you @Morgan-Sell

I just rebased on my branch and it worked. My suspicion is that it is related to how you sync (or not) the branches in your fork. You need to sync main and the feature branch in the fork remotely. Then fetch the changes locally. And then rebase. Not sure that's what you do. But that's the only thing I can think of really.