feature-engine / feature_engine

Feature engineering package with sklearn like functionality
https://feature-engine.trainindata.com/
BSD 3-Clause "New" or "Revised" License
1.8k stars 304 forks source link

add method to transfrom x and y to classes that drop rows from X, add pipeline to handle transform_x_y #724

Closed solegalli closed 3 months ago

solegalli commented 4 months ago
solegalli commented 4 months ago

Tests for new pipeline functionality are done.

I need to add remaining tests to corroborate that the original functionality of the pipeline (inherited from sklearn) also continues to work.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 98.18%. Comparing base (1a090ba) to head (946dc5e).

Files Patch % Lines
feature_engine/pipeline/pipeline.py 90.82% 7 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #724 +/- ## ========================================== - Coverage 98.31% 98.18% -0.14% ========================================== Files 103 105 +2 Lines 3928 4072 +144 Branches 764 795 +31 ========================================== + Hits 3862 3998 +136 - Misses 23 29 +6 - Partials 43 45 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.