feature-engine / feature_engine

Feature engineering package with sklearn like functionality
https://feature-engine.trainindata.com/
BSD 3-Clause "New" or "Revised" License
1.8k stars 304 forks source link

New feature: Lag or windows features grouped by #727

Open Ezzaldin97 opened 4 months ago

Ezzaldin97 commented 4 months ago

Create a New feature for the #668 issue

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.33%. Comparing base (1a090ba) to head (9d999b0). Report is 4 commits behind head on main.

:exclamation: Current head 9d999b0 differs from pull request most recent head 09db782. Consider uploading reports for the commit 09db782 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #727 +/- ## ========================================== + Coverage 98.31% 98.33% +0.01% ========================================== Files 103 103 Lines 3928 3965 +37 Branches 764 774 +10 ========================================== + Hits 3862 3899 +37 Misses 23 23 Partials 43 43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ezzaldin97 commented 3 months ago

hi @solegalli, I am looking forward to your feedback and any suggestions you may have to improve the pull request. Thank you in advance for your time and assistance.

Ezzaldin97 commented 3 months ago

Hi @solegalli I have updated, and pushed the latest changes according to your last instructions, but there is still no enhancement in lag_features.py file can be done, I have checked many solution to remove the loop when working with freq argument, but no one get the expected output. the unit test of CircleCI unexpectedly failed, I don't know why, but all tests passed on local image please advice to resolve this issue