search

feature-engine / feature_engine

Feature engineering package with sklearn like functionality
https://feature-engine.trainindata.com/
BSD 3-Clause "New" or "Revised" License
1.79k stars 304 forks source link

add support for 'auto' value in 'fold' parameter #755

Closed glevv closed 1 month ago

glevv commented 2 months ago

closes #754

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.23%. Comparing base (a347bc8) to head (6881055). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #755 +/- ## ========================================== + Coverage 98.18% 98.23% +0.05% ========================================== Files 105 105 Lines 4074 4085 +11 Branches 795 799 +4 ========================================== + Hits 4000 4013 +13 + Misses 29 28 -1 + Partials 45 44 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

solegalli commented 2 months ago

Hi @glevv Thank you so much for the super quick turnaround!

Could I ask you an additional change? Could you update the corresponding rst files within the user_guide in the docs file? It'd be important to reflect the current limits, and if you can give a shoutout at the auto parameter it would be great :)

Thank you!

solegalli commented 2 months ago

Thanks a lot!