Initial commit to test the GitHub workflow to fork and main. Code was…

feature-engine / feature_engine

Feature engineering package with sklearn like functionality

https://feature-engine.trainindata.com/

BSD 3-Clause "New" or "Revised" License

1.79k stars 304 forks source link

Initial commit to test the GitHub workflow to fork and main. Code was… #769

Closed olikra closed 2 weeks ago

olikra commented 3 weeks ago

… reformatted on the import statements and a new blank line between linenumber 73 and 74

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.52%. Comparing base (5f2bf8b) to head (4886f0a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #769 +/- ## ======================================= Coverage 97.52% 97.52% ======================================= Files 107 107 Lines 4283 4283 Branches 854 854 ======================================= Hits 4177 4177 Misses 62 62 Partials 44 44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

solegalli commented 3 weeks ago

Hey @olikra

The order of the imports is automatically taken care by isort. And the code style is adjusted with black. Both are python libraries. You don't need to change them manually.

olikra commented 2 weeks ago

Good morning @solegalli

I followed you very detailed onboarding instruction to get the fork locally running.

As mentioned I called isort and black. Isort did the reordering in the file - I did not resort them manually!

But i added manually the blank line here:

Anyway - in future I will let isort/black doing the work.

Will come back in the origin issue later today with a proposal how to migrate from pandas.agg to numpy.* It will get interesting...