search

feature-engine / feature_engine

Feature engineering package with sklearn like functionality
https://feature-engine.trainindata.com/
BSD 3-Clause "New" or "Revised" License
1.87k stars 310 forks source link

Test math features change daterange from t to min to avoid futurewarnings. #771

Closed olikra closed 3 months ago

olikra commented 3 months ago

Test math features change daterange from t to min to avoid futurewarnings.

Please review

olikra commented 3 months ago

@solegalli Tried to commit a "simple" change in test_math_feature. But circleci failed due to a deprecated version in numpy by version 2.0.0 which was released yesterday:

Bildschirmfoto 2024-06-17 um 11 52 17

In version 2.0.0 a test in test_check_discretisers.py failed:

=========================== short test summary info ============================
ERROR tests/test_discretisation/test_check_estimator_discretisers.py - AttributeError: `np.Inf` was removed in the NumPy 2.0 release. Use `np.inf`...

I used locally numpy 1.26.0 and the test worked. I will check it against numpy 2.0.0 locally

olikra commented 3 months ago

closed/reopen for new test