feature-engine / feature_engine

Feature engineering package with sklearn like functionality
https://feature-engine.trainindata.com/
BSD 3-Clause "New" or "Revised" License
1.79k stars 304 forks source link

Generell code coverage increasing #777

Open olikra opened 1 week ago

olikra commented 1 week ago

Added some missing tests on several classes - mainly on the init-part for classes @solegalli please have a look

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.87%. Comparing base (8cfab26) to head (b5fbbae).

Files Patch % Lines
feature_engine/creation/math_features.py 97.91% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #777 +/- ## ========================================== + Coverage 97.52% 97.87% +0.34% ========================================== Files 107 108 +1 Lines 4283 4329 +46 Branches 854 865 +11 ========================================== + Hits 4177 4237 +60 + Misses 62 54 -8 + Partials 44 38 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

olikra commented 5 hours ago

Forget this comment - I sorted it out. Keep track tomorrow or on Friday @solegalli tox got updated yesterday from 4.15.1 to 4.16. I did a tox-run localy with both versions and all went fine:

Bildschirmfoto 2024-07-03 um 17 59 28

On github the ci failed by an error in creation/CyclicalFeatures. But this class wasn't touched by me. I have no clue what's going on...