search

feature-sliced / documentation

🍰 Architectural methodology for frontend projects
https://feature-sliced.design
MIT License
1.5k stars 159 forks source link

Add React/ReduxToolkit example #570

Closed noveogroup-amorgunov closed 1 year ago

noveogroup-amorgunov commented 1 year ago

Background

Add actual react/redux example. I see current react/redux examples a bit outdated and simplified (only with one entity), so I think this example can everyone who want to see a more complex example

I will be glad to get project review

Changelog

netlify[bot] commented 1 year ago

Deploy Preview for pr-fsd ready!

Name Link
Latest commit 4eed41b0f8e6e05bba717e81fc09cab99a0fd731
Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/6446eb19f6842f0008c0d07e
Deploy Preview https://deploy-preview-570--pr-fsd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

noveogroup-amorgunov commented 1 year ago

@illright thank you for review. I add public api (index.ts) files for all segments in shared layer (api, ui, model and lib) and add comments about RFC inside @x/{entity} files.

Fixes in commit: https://github.com/noveogroup-amorgunov/nukeapp/commit/15d0fcf57e72ac366d2a86926ad1b678ccc646af

In general, I tried to use eslint rule for public api, but it works a bit weird (mark as error imports inside segments), so I have decided not to use it yet.