search

feature-sliced / documentation

🍰 Architectural methodology for frontend projects
https://feature-sliced.design
MIT License
1.5k stars 159 forks source link

Added project PseudoTube #639

Closed MaksimPir closed 7 months ago

MaksimPir commented 11 months ago

Background

Added my own project PseudoTube, it is an example of project where using FSD

Changelog

Added in /pages/examples/img/pseudoTube_screens.png Added in /pages/examples/config

netlify[bot] commented 11 months ago

Deploy request for pr-fsd rejected.

Name Link
Latest commit 88260936bb9cc447d8728fe2a8655f89197bb6d3
illright commented 11 months ago

Hey, thanks for the example! Didn't review the code yet, will do soon, but I have some preliminary comments in the meantime:

  1. Could you delete the .vs folder from your PR please?
  2. I see in your GitHub that you have a link to the preview, could you also add that?
MaksimPir commented 11 months ago

Hi! Added commit, please check it.

illright commented 10 months ago

I checked out the code and the architectural part feels pretty solid, but I'm really not a fan of the website design, namely, the colors. Could you change that?

MaksimPir commented 10 months ago

Hm... I think colors and design are subjective for everyone. In my opinion, this case suggests an example for learning how to use FSD in practice, and not about a beautiful web interface. The colors I chose for my application are not so ugly and do not hurt the eyes of users. If you can tell me the colors I should use, then I will change them

illright commented 10 months ago

Consider the visual style of well-established component libraries such as MUI, Ant Design, Carbon, etc. They often have a white background with high-contrast text and sparse use of accent colors.

illright commented 7 months ago

Closing this as stale