Implement `no-segments-on-sliced-layers` - Githubissues

feature-sliced / steiger

Universal file structure and project architecture linter

https://www.npmjs.com/package/steiger

MIT License

65 stars 4 forks source link

Implement `no-segments-on-sliced-layers` #25

Closed illright closed 2 months ago

illright commented 3 months ago

Sliced layers (Entities, Features, Widgets, Pages) should not have folders with conventional segment names in direct children.

[ ] Write the rule
[ ] Write positive test
[ ] Write negative test
[ ] Add documentation in form of a README and link that in the main README of the repo

daniilsapa commented 2 months ago

Hi guys! I have no experience in open-source software development yet. But I’m interested in it and would like to start somewhere. I chose this project because I really like FSD and have successfully implemented it in several projects in my company and my personal projects. I think you have done an outstanding job and I look forward to helping you where I can.

Could you assign this task to me? Or how it is done in your organization.

illright commented 2 months ago

Hi @daniilsapa! Glad to hear about your positive experience with FSD and thank you for taking the time to contribute. I assigned you to this ticket, so feel free to start working on it. If you need any help, I'll be here to answer any questions you have :)

daniilsapa commented 2 months ago

@illright Thank you! Starting working on it 👌

daniilsapa commented 2 months ago

@illright To avoid possible confusion, as far as I understand, there is a typo in the task description, instead of “Shared” it should say “Entities”. Because the "Shared" layer is just segmented.

illright commented 2 months ago

@daniilsapa yes, that's correct, fixed the description

daniilsapa commented 2 months ago

@illright I created a PR for this feature. Could you review it when you have time? Thank you in advance

daniilsapa commented 2 months ago

Quality checks failed for my PR and I think I know why. I'm fixing it