feature23 / StringSimilarity.NET

A .NET port of java-string-similarity
Other
448 stars 70 forks source link

Lower the targeted framework to 4.5. #9

Closed cscorley closed 7 years ago

cscorley commented 8 years ago

I could not use this package in my project because we require targeting 4.5, but this targeted 4.5.2. Seems unnecessary to target a minor version like this; the tests pass without it. This could probably target lower versions, as well.

The primary reference "F23.StringSimilarity, Version=1.1.1.0, Culture=neutral, processorArchitecture=MSIL" could not be resolved because it was built against the ".NETFramework,Version=v4.5.2" framework. This is a higher version than the currently targeted framework ".NETFramework,Version=v4.5".
paulirwin commented 8 years ago

Thanks @cscorley for the submission!

While I approve this, please note that this will be a temporary measure. .NET Framework 4.5 and 4.5.1 are no longer supported by Microsoft since January 2016 and so, if needed, we may revert this change later to support 4.5.2 or possibly even 4.6+. I don't see us needing to do that within the next three months though, so this will give users until a year out from the end-of-life.

cscorley commented 8 years ago

Understandable. If that becomes the issue for us, we will likely just maintain a separate build -- or remain on whatever the last archived version is on nuget -- until we can start targeting higher ourselves 😄

paulirwin commented 8 years ago

Thanks for your patience @cscorley, we're going to get this released very soon now that #10 is also ready.