featurecat / lizzie

Lizzie - Leela Zero Interface
GNU General Public License v3.0
970 stars 228 forks source link

Add "Edit/Copy comment" into Game menu #880

Open kaorahi opened 3 years ago

kaorahi commented 3 years ago

Alternatively...

This PR is just a workaround for #806 until someone will implement #806 itself.

hope366 commented 3 years ago

If you write double-byte characters in the comment area, you will not be able to turn analysis on or off. You can turn the analysis on and off by entering additional half-width characters.

kaorahi commented 3 years ago
  1. Did you turn off IME (Japanese input mode) before hitting SPACE key to toggle pondering?
  2. Would you try the same operations as your previous comment on https://github.com/kaorahi/lizzie/tree/for806_comment_io2 (20824c5b) ?
hope366 commented 3 years ago

I solved it by inputting half-width alphanumeric characters before hitting the space key. Thank you for your advice. I tried 20824c5, but I wasn't sure what the difference was before and after it was applied.

kaorahi commented 3 years ago

No! "inputting half-width alphanumeric characters before hitting the space key" is not a solution but just a workaround. Such "bad know-how" makes Lizzie too difficult for typical Go fans who does not have high skill in computers. It is unhappy for us, isn't it? :-)

As I have no Windows machine, I cannot debug issues on Windows unless someone gives me sufficient information. If you would help debugging for not only you but also other nontechnical users, please follow my requests exactly and tell me the results.

(A) On https://github.com/kaorahi/lizzie/tree/for806_comment_io (9b53d938)

  1. Start Lizzie and select Game > Edit Comment.
  2. Input Japanese ("double-width") characters.
  3. Turn off IME (= Turn off "Japanese input mode") and click OK button.
  4. Hit SPACE key.

Can you toggle pondering in Step 4?

(B) On https://github.com/kaorahi/lizzie/tree/for806_comment_io2 (20824c5b)

  1. Start Lizzie and select Game > Edit Comment.
  2. Input Japanese ("double-width") characters.
  3. Keeping IME on (= Keeping "Japanese input mode"), click OK button.
  4. Hit SPACE key.

Can you toggle pondering in Step 4?

Be careful: Step 3 is different between (A) and (B).

hope366 commented 3 years ago

(A) and (B) were each verified by compiling the source code downloaded from the specified links.

In case (A), it was possible to toggle pondering. In case (B), it was not possible to toggle pondering.

kaorahi commented 3 years ago

thx!

How about (B) on https://github.com/kaorahi/lizzie/tree/for806_comment_io3 (32436d56) ?

hope366 commented 3 years ago

I tried https://github.com/kaorahi/lizzie/tree/for806_comment_io3, but I couldn't switch the pondering with the space key in Japanese input mode. By the way, the analysis switching button on the lower toolbar works even in the Japanese input mode. (Same for https://github.com/kaorahi/lizzie/tree/for806_comment_io2)

kaorahi commented 3 years ago

Hmm...

On https://github.com/kaorahi/lizzie/tree/for806_comment_io3 (32436d56), I expect that "Japanese input mode" is automatically turned off when you click OK button in Step 3. This gimmick doesn't work?

hope366 commented 3 years ago

When I clicked the OK button in step 3, the IME display at the bottom right flashed for a moment. In other words, if you click the OK button, the Japanese input mode will be canceled, but you will soon be in the Japanese input mode again.

kaorahi commented 3 years ago

Oh, strange. I don't think I can solve this issue without help from Windows programmers. Thanks anyway for your reports.

yzyray commented 3 years ago

Maybe we can solve the IME issue by disable LizzieFrame mainPanel's IME, mainPanel.enableInputMethods(false);

kaorahi commented 3 years ago

thx!

@hope366, can you try the above (B) on https://github.com/kaorahi/lizzie/tree/for806_comment_io4 (459cbbf0) with both Normal UI and Panel UI?

hope366 commented 3 years ago

https://github.com/featurecat/lizzie/commit/459cbbf0a93bd44f689a6a64d26c1b6b6c4f4aa7 I tried this. In both normal mode and panel UI mode, IME automatically switches to half-width alphanumeric mode by clicking the "OK" button after full-width input! !!

kaorahi commented 3 years ago

Then 459cbbf0 seems ok. :)

I added it to this PR.