search

featurecat / lizzie

Lizzie - Leela Zero Interface
GNU General Public License v3.0
970 stars 228 forks source link

Score mean display incorrect #901

Open w3333 opened 3 years ago

w3333 commented 3 years ago

Hi,

I presume the setting for score mean with/without komi is reversed. When I set it to "score mean" without komi, I expect a score estimate of around 6.5 on the empty board. When set to "score mean + komi" it should be around 0, right? It is exactly the other way around, see screenshots. If I misunderstand please apologize. But it is rather confusing this way.

Bildschirmfoto vom 2021-10-22 20-27-32 Bildschirmfoto vom 2021-10-22 20-25-50

kaorahi commented 3 years ago

KataGo's "ScoreMean" is defined as the score with komi. So "+Komi" intends "cancel komi" actually. :(

I agree that these labels are confusing for most users. I have two options.

But I am hesitating because...

(Note for programmers: See git grep showKataGoBoardScoreMean.)

w3333 commented 3 years ago

Ok. That's weird but of course that happens. And how about making the label depending on the engine? Weird too? I don't know. Someone will always be confused I guess. I finally figured this out after 3 years... so now I can live with it either way. Just seems a bit suboptimal the way it is now. I think most people will want to see the score with komi. Why wouldn't you... so that should be what you see by default, regardless of the engine. Only some special use case will need the score without komi. Which could be some checkbox in settings?

Anyway. It's up to you of course. I'm already happy you agree that it is confusing :)

killerducky commented 3 years ago

I suggest removing the score without komi function. Keep it simple.

w3333 commented 3 years ago

Another possibility might be to remove the "without komi" option completely, like @killerducky suggests, and display the komi somewhere prominent in the score graph, so that it is clear on first sight what the numbers mean. Then it would be (supposedly) clear that all score estimates are including komi (using kata), and whether that is 6.5, 5.5, 0.5 or something else would be visible all the time (which would be nice anyway since it's a vital game info). I don't know about leelaz, but if you see the score values and the komi together, on the empty board it should be clear to everbody whether the scoremean includes komi or not.