search

featurehub-io / featurehub-helm

Official FeatureHub Helm charts
4 stars 4 forks source link

Add PodDisruptionBudget for dacha, edge and managementRepository #7

Closed matejhasul closed 1 year ago

matejhasul commented 1 year ago

We are missing PDB in our deployment.

Signed-off-by: Matej Hasul matej.hasul@gooddata.com

matejhasul commented 1 year ago

Should I bump also the chart version?

matejhasul commented 1 year ago

@rvowles @IrinaSouth would you mind checking this?

rvowles commented 1 year ago

yes @matejhasul - if you can bump the chart version we can merge it straight up and it will release the new version.

rvowles commented 1 year ago

Oh, and you also need to regenerate the docs and commit them in as well

rvowles commented 1 year ago

The helm doc generator is part of the github pipeline, the issue being we release on merge to main - so the docs need to be up to date :-) ref is here: https://github.com/featurehub-io/featurehub-helm/blob/main/.github/helm-docs.sh

matejhasul commented 1 year ago

@rvowles Done. Should I squash the fixups or it will be done automatically upon merge?

rvowles commented 1 year ago

squashed on merge :-) thanks for your contribution @matejhasul !

matejhasul commented 1 year ago

@rvowles Thanks for quick review&merge.